test: migrate client module api tests to junit 5 #4377
Conversation
sherlock-lin
force-pushed
the
sherlock-migrate-to-junit5-0516
branch
2 times, most recently
from
bcc59bb
to
da302e5
Compare
sherlock-lin
force-pushed
the
sherlock-migrate-to-junit5-0516
branch
from
da302e5
to
e85971e
Compare
sherlock-lin
force-pushed
the
sherlock-migrate-to-junit5-0516
branch
6 times, most recently
from
407fc29
to
f0aa9af
Compare
sherlock-lin
force-pushed
the
sherlock-migrate-to-junit5-0516
branch
from
f0aa9af
to
859af11
Compare
| /** | ||
| * Unit Test Context Information. | ||
| */ | ||
| public class TestContextExtension implements BeforeEachCallback { |
There was a problem hiding this comment.
I think we can put this common class into testtools, WDYT?
There was a problem hiding this comment.
I think we can put this common class into
testtools, WDYT?
Of course, I would also like this class to become more generalized, how do I add it to testtools please?
There was a problem hiding this comment.
This class isn't needed. Junit5 already contains TestInfo for this purpose.
Please check https://junit.org/junit5/docs/current/user-guide/#writing-tests-dependency-injection for the example.
|
@lhotari Thanks for you remind, I remember this class too, and it has been used in |
| public static Collection<Object[]> data() { | ||
| return Arrays.asList(new Object[][]{ | ||
| {true}, | ||
| {false} | ||
| }); | ||
| } | ||
|
|
||
| @Test | ||
| public void testOpenLedger() throws Exception { | ||
| @MethodSource("data") |
There was a problem hiding this comment.
In junit5, it's better to use @ValueSource(booleans = {true, false}) for cases where there's a single boolean parameter.
There was a problem hiding this comment.
@lhotari Thanks，It's a better choice.
sherlock-lin
force-pushed
the
sherlock-migrate-to-junit5-0516
branch
2 times, most recently
from
8cb695d
to
2615c36
Compare
sherlock-lin
force-pushed
the
sherlock-migrate-to-junit5-0516
branch
from
2615c36
to
84335b9
Compare
done :) |
| @@ -264,6 +267,7 @@ private DigestManager getDigestType(long ledgerId) throws GeneralSecurityExcepti | |||
| UnpooledByteBufAllocator.DEFAULT, false); | |||
| } | |||
|
|
|||
| @AfterEach | |||
| @After | |||
There was a problem hiding this comment.
how about add some todo here: // TODO: delete @Before when only run with junit5
| @@ -141,6 +143,7 @@ public MockEntry(byte[] payload, long lastAddConfirmed) { | |||
|
|
|||
| } | |||
|
|
|||
| @BeforeEach | |||
| @Before | |||
There was a problem hiding this comment.
how about add some todo here: // TODO: delete @Before when only run with junit5
Descriptions of the changes in this PR:
Fix #4322
Main Issue: #4322