Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie #712

Closed
wants to merge 9 commits into from
Closed

Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie #712

wants to merge 9 commits into from

Commits on Nov 10, 2017

  1. Issue 544: Bootup cookie validation considers an empty journal to sig… 

    …nify a new bookie

- read cookie from registration manager as the source-of-truth (for all potential options)
- remove duplicated code between checkEnvironment and checkEnvironmentWithStorageExpansion
    @sijie
    sijie committed Nov 10, 2017
    Configuration menu
    Copy the full SHA
    42b7b04 View commit details
    Browse the repository at this point in the history

  2. Fix test case

    @sijie
    sijie committed Nov 10, 2017
    Configuration menu
    Copy the full SHA
    25c75fa View commit details
    Browse the repository at this point in the history

  3. Address comments

    @sijie
    sijie committed Nov 10, 2017
    Configuration menu
    Copy the full SHA
    5f73324 View commit details
    Browse the repository at this point in the history

  4. use unknown

    @sijie
    sijie committed Nov 10, 2017
    Configuration menu
    Copy the full SHA
    6100378 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2017

  1. Refactor to make expansion more explicit 

    Explicitly pass allowExpansion rather than the whole configuration, so
it's clear which methods are taking it into account.

Renames the verification for old directories in the case of storage
expansion.

Remove return statement from middle of method.
    @ivankelly @sijie
    ivankelly authored and sijie committed Nov 15, 2017
    Configuration menu
    Copy the full SHA
    07de728 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2017

  1. Merge branch 'master' into fix_cookie_issue

    @sijie
    sijie committed Nov 16, 2017
    Configuration menu
    Copy the full SHA
    4ee0b31 View commit details
    Browse the repository at this point in the history

  2. Fix findbugs error

    @sijie
    sijie committed Nov 16, 2017
    Configuration menu
    Copy the full SHA
    1e24bc8 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2017

  1. Fix BookieInitializtionTEst

    @sijie
    sijie committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    e684ecb View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2017

  1. Address comments

    @sijie
    sijie committed Nov 22, 2017
    Configuration menu
    Copy the full SHA
    fe5304d View commit details
    Browse the repository at this point in the history