Fixed simultaneus reads on same ledger/entry with v2 protocol #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FAILURE --none-- |
jiazhai
reviewed
Nov 12, 2017
| * | ||
| * @throws Exception | ||
| */ | ||
| @Test(timeout = 20000) |
There was a problem hiding this comment.
Remove timemout?
I recall there was a require to remove all the "timeout", since we have a global timeout set in surefire configuration.
| * | ||
| * @throws Exception | ||
| */ | ||
| @Test(timeout = 20000) |
jiazhai
approved these changes
Nov 12, 2017
ivankelly
requested changes
Nov 13, 2017
| @@ -845,6 +846,56 @@ private void writeAndFlush(final Channel channel, | |||
| errorOut(key); | |||
| } | |||
| } | |||
|
|
|||
| void errorOutReadKey(final CompletionKey key) { | |||
There was a problem hiding this comment.
This code isn't valid anymore. Erroring out is now part of the completionValue, so this should be handled there.
| } | ||
| } | ||
|
|
||
| final Channel c = channel; |
There was a problem hiding this comment.
This is handled in writeAndFlush now. You'll need to add a check for the conflicts map into the #errorOut method.
There was a problem hiding this comment.
Ok, I've missed that part. I'll fix that
|
@merlimat @ivankelly : any updates on this PR? I was lost who is picking up pr. |
|
I made a PR into matteo's branch. When he merges that, this will be ready
for review again
…On Mon 4 Dec 2017, 08:43 Sijie Guo ***@***.***> wrote:
@merlimat <https://github.com/merlimat> @ivankelly
<https://github.com/ivankelly> : any updates on this PR? I was lost who
is picking up pr.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#720 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADWqxD7lmLtY82ddCv3dIlQkH87zRQvks5s86KngaJpZM4QaZxa>
.
|
merlimat
force-pushed
the
concurrent-read-v2
branch
from
73473f6
to
d8a14e3
Compare
|
Rebased and applied fixes from @ivankelly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is coming from yahoo branch at YahooArchive/bookkeeper@ce7b0f7
With v2 protocol there's no way to disambiguate the read request since the completion key is made from (ledgerId, entryId).
This PR introduced an additional multimap to handle the conflicts (multiple simultaneus read requests for the same entry).