Issue-689 improve release guide for minor versions #777
Conversation
|
see #689 for description of changes |
| @@ -234,21 +244,14 @@ Use Maven release plugin to create the release branch and update the current bra | |||
| > $ git reset --hard apache/<master branch OR release tag> | |||
| > $ git branch -D ${BRANCH_NAME} | |||
|
|
|||
| However, if you are doing an incremental/hotfix release, please run the following command after checking out the release tag of the release being patched. | |||
There was a problem hiding this comment.
@sijie I thought that "incremental/hotfix" is a synonym for "minor"
There was a problem hiding this comment.
yes. but my question is why do you removing the command below. They should be different commands, no?
There was a problem hiding this comment.
for a minor (4.5.2) release you do not have to use that command, it will create a new branch, but it this case the branch is already here (branch-4.5 in my case)
| @@ -378,10 +381,10 @@ Start the review-and-vote thread on the dev@ mailing list. Here’s an email tem | |||
| * All artifacts to be deployed to the Maven Central Repository [3] | |||
| * Source code tag "release-4.5.0" [4] | |||
|
|
|||
| BookKeeper's KEY file contains PGP keys we use to sign this release: | |||
| BookKeeper's KEYS file contains PGP keys we used to sign this release: | |||
There was a problem hiding this comment.
Just because while sending the email you have already signed the artifacts, it is on the past, maybe my English is not very good.
Maybe I can reword as
"BookKeeper's KEYS file contains PGP keys we use to sign this releases:"
| @@ -447,6 +450,18 @@ Once all issues have been resolved, you should go back and build a new release c | |||
|
|
|||
| Once the release candidate has been reviewed and approved by the community, the release should be finalized. This involves the final deployment of the release candidate to the release repositories, merging of the website changes, etc. | |||
|
|
|||
| ### Advance version on release branch | |||
There was a problem hiding this comment.
can't maven:release plugin handle this?
There was a problem hiding this comment.
AFAIK this is not done in the current procedure, in fact Jia for 4.6 release left the version to "4.6.0-SNAPSHOT" and I left it to "4.5.1-SNAPSHOT" and JV to "4.5.0-SNAPSHOT"
so some command is missing, or maybe there is another better way to bump version
There was a problem hiding this comment.
I think mvn:release does bump the major version when creating the branch. I need to check out the commands.
There was a problem hiding this comment.
anyway in my example I am using the mvn release plugin with the "update-versions" mojo
There was a problem hiding this comment.
and after releasing 4.6.0 (major version) you should have 4.6.1-SNAPSHOT, maybe Jia and JV used the wrong command
There was a problem hiding this comment.
Right, as @sijie mentioned, it is create when we creating the branch, but seems version not bumped in the release target branch.
|
Overall LGTM. Since we have turn into github only, It is OK to remove all Jira related things in the documentation? @eolivelli @sijie |
|
@jiazhai @ivankelly has another task to clean up the website from JIRA entirely |
No description provided.