Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 230: Enable Checkstyle on the tls package #779

Closed
wants to merge 1 commit into from

Conversation

acoburn
Copy link
Member

@acoburn acoburn commented Nov 27, 2017

This is part of #230 and adds Checkstyle verification to the TLS package in bookkeeper-server.

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 lgtm thank you!

Copy link
Member

@jiazhai jiazhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. will merge this.

@jiazhai jiazhai added this to the 4.7.0 milestone Nov 28, 2017
@jiazhai jiazhai closed this in ad546ae Nov 28, 2017
@acoburn acoburn deleted the checkstyle_tls branch November 28, 2017 14:25
athanatos pushed a commit to athanatos/bookkeeper that referenced this pull request Jan 25, 2019
- move to spotbugs 3.1.9
- disable spotbugs on contrib package
- fix spotbugs warnings on recipes
- add commons-lang 2.6 dependency in order to fix build

Author: Enrico Olivelli <eolivelli@apache.org>

Reviewers: andor@apache.org

Closes apache#779 from eolivelli/fix/ZOOKEEPER-3223-master-part2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants