[BROOKLYN-280] add --skipSslChecks flag to work with self-signed certs #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- defaults to false, ie existing behaviour - setting to true disables certificate chain and hostname verificiation (see `InsecureSkipVerify` in https://golang.org/pkg/crypto/tls/) - persisted to ~/.brooklyn_cli ``` bash-4.3$ br login https://10.10.10.100:8443/ admin password Get https://10.10.10.100:8443/v1/server/version: x509: certificate signed by unknown authority bash-4.3$ br app Get https://10.10.10.100:8443/v1/applications: x509: certificate signed by unknown authority bash-4.3$ br --skipSslChecks login https://10.10.10.100:8443/ admin password Connected to Brooklyn version 0.10.0-20160513.2042 at https://10.10.10.100:8443 bash-4.3$ br app Id Name Status Location ```
johnmccabe
changed the title
| @@ -39,7 +39,7 @@ var appConfig = configDefaults{ | |||
| Name: os.Args[0], | |||
| HelpName: os.Args[0], | |||
| Usage: "A Brooklyn command line client application", | |||
| Version: "0.9.0", | |||
| Version: "0.10.0-SNAPSHOT", | |||
There was a problem hiding this comment.
Add an inline comment BROOKLYN_VERSION, or a comment on the line above BROOKLYN_VERSION_BELOW to have this changed automatically.
There was a problem hiding this comment.
thanks @neykov forgot about that
|
I'm tempted to change the flag to match wdyt? |
|
+1 to matching curl |
|
👍 LGTM, I have pulled and tested this and it works well. Think this is a valuable addition to the tool. |
|
I don't think this necessarily needs to change to match the "-k / --insecure" of curl, the current flag has a nicely meaningful name. |
|
Thanks @geomacy should be good to merge now |
asfgit
pushed a commit
that referenced
this pull request
May 30, 2016
[BROOKLYN-280] add --skipSslChecks flag to work with self-signed certs - defaults to `false`, ie existing behaviour - setting the flag `--skipSslChecks` disables certificate chain and hostname verification (see `InsecureSkipVerify` in https://golang.org/pkg/crypto/tls/) - persisted to `~/.brooklyn_cli` - also bumped version to `0.10.0-SNAPSHOT` ``` bash-4.3$ br login https://10.10.10.100:8443/ admin password Get https://10.10.10.100:8443/v1/server/version: x509: certificate signed by unknown authority bash-4.3$ br app Get https://10.10.10.100:8443/v1/applications: x509: certificate signed by unknown authority bash-4.3$ br --skipSslChecks login https://10.10.10.100:8443/ admin password Connected to Brooklyn version 0.10.0-20160513.2042 at https://10.10.10.100:8443 bash-4.3$ br app Id Name Status Location ``` *Note*: I'd no apps running on this system so the empty table is ok, catalog returns as expected. ```json { "auth": { "https://10.10.10.100:8443": { "password": "password", "username": "admin" } }, "skipSslChecks": true, "target": "https://10.10.10.100:8443" } ```
andreaturli
pushed a commit
to andreaturli/brooklyn-client
that referenced
this pull request
Sep 9, 2016
Add stop, start and restart commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
false, ie existing behaviour--skipSslChecksdisables certificate chain and hostname verification (seeInsecureSkipVerifyin https://golang.org/pkg/crypto/tls/)~/.brooklyn_cli0.10.0-SNAPSHOTNote: I'd no apps running on this system so the empty table is ok, catalog returns as expected.
{ "auth": { "https://10.10.10.100:8443": { "password": "password", "username": "admin" } }, "skipSslChecks": true, "target": "https://10.10.10.100:8443" }