Add NOTICE file to Karaf distribution. #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neykov
reviewed
Dec 7, 2016
| <directory>${basedir}/target/classes/META-INF</directory> | ||
| <includes> | ||
| <include>NOTICE</include> | ||
| </includes> |
There was a problem hiding this comment.
The NOTICE file created in target/classes/META-INF contains
Brooklyn Karaf Distribution
Copyright 2012-2016 The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
while Brooklyn's files contain:
Apache Brooklyn
Copyright 2014-2016 The Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
I believe this will copy Karaf's NOTICE in Brooklyn's distribution.
You can copy the file along the existing LICENSE from elsewhere in the source tree. No need to maven foo.
There was a problem hiding this comment.
thanks @neykov will update
geomacy
force-pushed
the
add-notice-to-karaf
branch
from
3336d31
to
d6ec911
Compare
|
change squashed and pushed |
asfgit
pushed a commit
that referenced
this pull request
Dec 7, 2016
|
Thanks, merged in master and cherry-picked on the 0.10.0 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.