Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure Classic and ARM docs #140

Merged
merged 2 commits into from
Jan 19, 2017
Merged

Conversation

drigodwin
Copy link
Member

Adds Azure Classic and Azure ARM usage details to the documented locations.

Copy link
Contributor

@Graeme-Miller Graeme-Miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but some minor changes

Azure is a cloud computing platform and infrastructure created by Microsoft. Apache Brooklyn includes support for both Azure Classic and Azure ARM, as
one of the [Apache jclouds](http://jclouds.org) supported clouds `Microsoft Azure Compute`.

The two modes of using Azure are the "classic deployment" model and the newer "resource manager deployment" (ARM)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use "Azure resource manager" rather than "resource manager deployment" so the acronym makes sense?

one of the [Apache jclouds](http://jclouds.org) supported clouds `Microsoft Azure Compute`.

The two modes of using Azure are the "classic deployment" model and the newer "resource manager deployment" (ARM)
model. See https://azure.microsoft.com/en-gb/documentation/articles/resource-manager-deployment-model/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be a link


* `useJcloudsSshInit: false` tells jclouds to not try to connect to the VM

* `vmNameMaxLength: 15` tells the cloud client to strip the VM to maximum 15 characters.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should say "strip the VM name"

authentication mechanisms, so this may be changed to a prioritised list so as to
provide fallback options.

* `user` tells Apache Brooklyn the user to login as (in this case using WinRM).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"in this case" not sure I understand what the case is here?

For Windows on Azure, the value should match that supplied in the `overrideLoginUser` of
the `templateOptions`.

* `password`: tells Apache Brooklyn the password to use when connecting (in this case using WinRM).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above comment, don't understand the sue of case

templateOptions:
overrideAuthenticateSudo: true

The loginUser can be anything, as long as it's specified.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should mention what overrideAuthenticateSudo does

templateOptions:
overrideAuthenticateSudo: true

Fill the values `<Application-id>`, `<Password>`, `<Subscription-id>` and `<Tenant-id>` in from the values generated when
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting weird paragraph breaks when viewing this locally. See attached screen shot. It doesn't look like the examples are in the same section as the explanation underneath them.
screen shot 2017-01-19 at 14 56 28

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a scroll bar, what browser/OS are you using?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this might be specific to me. This looks good to merge

@geomacy
Copy link
Contributor

geomacy commented Jan 19, 2017

Looks good at a quick scan for general issues (can't comment on the specifics of the settings/config for Azure as such), so if Graeme is happy then I'm happy to merge.

@asfgit asfgit merged commit 56eff40 into apache:master Jan 19, 2017
asfgit pushed a commit that referenced this pull request Jan 19, 2017
Add Azure Classic and ARM docs

Adds Azure Classic and Azure ARM usage details to the documented locations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants