Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use servicemix bundle of xstream at runtime #1043

Merged
merged 1 commit into from Feb 12, 2019
Merged

Use servicemix bundle of xstream at runtime #1043

merged 1 commit into from Feb 12, 2019

Conversation

kemitix
Copy link
Contributor

@kemitix kemitix commented Feb 12, 2019

The updated xstream includes dependencies on libraries that are not
OSGi bundles. This servicemix repackaging, includes these libraries
within the bundle.

Follows on from #1038

The updated xstream includes dependencies on libraries that are not
OSGi bundles. This servicemix repackaging, includes these libraries
within the bundle.
Copy link
Contributor

@duncangrant duncangrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks @kemitix

@ahgittin
Copy link
Contributor

resulting assembly works fine - great fix @kemitix , merging

@asfgit asfgit merged commit 8f6c871 into apache:master Feb 12, 2019
asfgit pushed a commit that referenced this pull request Feb 12, 2019
@kemitix kemitix deleted the dependabot/maven/upgrades/com.thoughtworks.xstream-xstream-1.4.11.1 branch February 12, 2019 12:00
@jcabrerizo
Copy link
Contributor

I get this message in the console:

Security framework of XStream not initialized, XStream is probably vulnerable.

It's not more vulnerable than before, but have this trace may be a problem

@kemitix
Copy link
Contributor Author

kemitix commented Feb 12, 2019

This explains the sort of thing we would need to add to fix this: https://stackoverflow.com/a/45152845

Specifically:

XStream.setupDefaultSecurity(this); // to be removed after 1.5
xstream.allowTypesByWildcard(new String[] {
    "com.your.package.**"
});

We would need to know which packages would need to be be added, and where to set this.

@jcabrerizo
Copy link
Contributor

I did a fast test adding org.apache.brooklyn and it I couldn't run Brooklyn after that. Better leave this as is for the moment and make a detailed analysis later

@duncangrant
Copy link
Contributor

@kemitix @jcabrerizo please track this as a bug on issues.apache.org - I'd add it but I seem to be unable to get past the captcha.

@ahgittin
Copy link
Contributor

Solution is probably to set * in a cfg file in the dist and to read this on management initialization. People can edit this subsequently.

To avoid the errors in test and non-osgi the code can say if there is no such cfg fie it sets * as a default with a log debug message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants