-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use servicemix bundle of xstream at runtime #1043
Use servicemix bundle of xstream at runtime #1043
Conversation
The updated xstream includes dependencies on libraries that are not OSGi bundles. This servicemix repackaging, includes these libraries within the bundle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - thanks @kemitix
resulting assembly works fine - great fix @kemitix , merging |
I get this message in the console:
It's not more vulnerable than before, but have this trace may be a problem |
This explains the sort of thing we would need to add to fix this: https://stackoverflow.com/a/45152845 Specifically:
We would need to know which packages would need to be be added, and where to set this. |
I did a fast test adding |
@kemitix @jcabrerizo please track this as a bug on issues.apache.org - I'd add it but I seem to be unable to get past the captcha. |
Solution is probably to set To avoid the errors in test and non-osgi the code can say if there is no such |
The updated xstream includes dependencies on libraries that are not
OSGi bundles. This servicemix repackaging, includes these libraries
within the bundle.
Follows on from #1038