Fix for BROOKLYN-314 #267
Merged
Fix for BROOKLYN-314 #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try-catch in getOptionalNode/getOptionalImage (e.g. if called by user in rebind code, then don’t fail outright if cloud throws exception
|
Looks good, and pretty straightforward. Could you add a test for the rebind issue described in #BROOKLYN-314 |
|
@nakomis not particularly easily is the answer, for writing a test to recreate BROOKLYN-314! Would need to stub-out the a JcloudsLocation to simulate the failure, and to write a custom entity and an associated driver that calls I'll have more of a look at doing that, but am going to merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try-catch in getOptionalNode/getOptionalImage (e.g. if called by user
in rebind code, then don’t fail outright if cloud throws exception