BROOKLYN-354: Rebind failed (when an NingxController entity's hostname sensor was null) #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! |
|
All tests are passing. LGTM. |
|
The test failure looks unrelated. It failed while building Brooklyn CAMP REST API (after 30:21 min): It had just run |
aledsage
force-pushed
the
BROOKLYN-354
branch
from
e52c903
to
598059c
Compare
|
The jenkins build got past core and software-base (i.e. the code that this PR touches) before timing out, so I'm going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in https://issues.apache.org/jira/browse/BROOKLYN-354, the underlying issue was already fixed in master. This just adds unit tests for it.