BROOKLYN-409: add test #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aledsage
force-pushed
the
BROOKLYN-409
branch
from
c0fe24d
to
92d67a2
Compare
neykov
approved these changes
Dec 16, 2016
| " item:", | ||
| " services:", | ||
| " - type: " + TestEntity.class.getName()); | ||
| addCatalogItems(yaml1); |
There was a problem hiding this comment.
addCatalogItems supports String... catalogYaml - no need to join them above.
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-jar-plugin</artifactId> | ||
| <version>2.3.2</version> |
There was a problem hiding this comment.
The version is already defined (albeit a different one) in parent pom, remove from there.
Same for below.
Includes new osgi test bundle with prefix "com.example.brooklyn"
aledsage
force-pushed
the
BROOKLYN-409
branch
from
92d67a2
to
ed560a7
Compare
|
Thanks @neykov - changes incorporated, and squashed into single commit. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes new osgi test bundle with prefix "com.example.brooklyn"
Without that new osgi bundle, the test might only pass because of the "white-listing" of org.apache.brooklyn prefixes. As the comment in the relevant pom.xml says, it's ok to use this mavenId that we don't own because the artifact is only used for test purposes. It is never part of a release.
For BROOKLYN-409, this test shows that it is already fixed in master! I believe it was fixed in this commit: