Make the Repeater class use a threads to execute the checks #493

grkvlt · 2016-12-15T17:24:10Z

The Future returned by the Executor can be cancelled if it does not return a value after the required timeout.

geomacy · 2016-12-16T10:45:43Z

hi @grkvlt looks good at an initial glance, but are there tests that could be added to demonstrate the improvement?

neykov · 2016-12-16T16:14:04Z

I like the idea, very useful sometimes.

Brooklyn already spins up a huge number of threads and this change will add even more even if not needed (tasks needs cancelling). Do you think each task will benefit from the change? If not, what if we provide a wrapper to Repeater to be used selectively?
Could be a very thin wrapper which passes a wrapped body which is executed in a separate thread. The body executed by the repeater just does future.get(timeout).

aledsage · 2017-01-05T16:08:03Z

@grkvlt I agree with @neykov's concern about thread usage. Maybe we could make it configurable, so the default is the existing behaviour (which would use a guava MoreExecutors.directExecutor()), and only a new single-threaded executor if configured to do so.

grkvlt · 2017-01-11T09:11:08Z

@neykov @aledsage @geomacy thanks for the feedback, I'll make this configurable and add some tests

grkvlt · 2017-01-26T15:47:19Z

@neykov @aledsage I used MoreExecutors.sameThreadExecutor() as the default, but added threaded() and threaded(ExecutorService) methods for the builder to change to either Executors.newSingleThreadExecutor() or whatever the user wants.

neykov

Looking great, only concern is shutting down the executor if passed from the outside.

neykov · 2017-01-26T16:23:25Z

utils/common/src/main/java/org/apache/brooklyn/util/repeat/Repeater.java

    public ReferenceWithError<Boolean> runKeepingError() {
-        Preconditions.checkState(body != null, "repeat() method has not been called to set the body");


Any reason to remove the body != null check?

Should have been changed to a checkNotNull() call

neykov · 2017-01-26T16:41:57Z

utils/common/src/main/java/org/apache/brooklyn/util/repeat/Repeater.java

-
-            Time.sleep(delayThisIteration);
+        } finally {
+           executor.shutdownNow();


Don't shut down if passed from caller.

neykov · 2017-01-26T16:44:23Z

utils/common/src/main/java/org/apache/brooklyn/util/repeat/Repeater.java

+
+                Future<?> call = executor.submit(body);
+                try {
+                    call.get(delayThisIteration.toMilliseconds(), TimeUnit.MILLISECONDS);


I think a separate time out is needed here, especially when used with backoff, but happy to go with this.

neykov · 2017-02-03T16:50:05Z

utils/common/src/main/java/org/apache/brooklyn/util/repeat/Repeater.java

+     */
+    public Repeater threaded(ExecutorService executor) {
+        this.executor = executor;
+        return this;


A bit on the pedantic side - can you add shutdown =false here. Can imagine first calling threaded() and passing the builder to another method only to add a custom executor using threaded(myExecutor). Good to merge after that.

grkvlt · 2017-02-06T14:59:11Z

@neykov have a look now, I updated the comments to be more explicit too

neykov · 2017-02-06T21:17:32Z

...src/main/java/org/apache/brooklyn/entity/software/base/lifecycle/LifecycleEffectorTasks.java

@@ -0,0 +1,1072 @@
+/*


Was this file committed by mistake? LGTM otherwise.

neykov · 2017-02-07T16:33:10Z

Thanks for updates @grkvlt, merging.

Make the Repeater class use a threads to execute the checks The Future returned by the Executor can be cancelled if it does not return a value after the required timeout.

Make the Repeater class use a threads to execute the checks

beed8c1

The Future returned by the Executor can be cancelled if it does not return a value after the required timeout.

Make threaded repeater configurable during creation

a9b945e

grkvlt force-pushed the enhancement/threaded-repeater branch from 46cb2d7 to a9b945e Compare January 26, 2017 15:45

neykov suggested changes Jan 26, 2017

View reviewed changes

Only shut down the SingleThreadExecutor we control in the repeater

68664b8

grkvlt force-pushed the enhancement/threaded-repeater branch 3 times, most recently from f877b39 to 2003b4b Compare February 2, 2017 17:49

Check for NPE in tests and use isPositive check for Duration

d6041d4

grkvlt force-pushed the enhancement/threaded-repeater branch from 2003b4b to d6041d4 Compare February 2, 2017 18:33

neykov reviewed Feb 3, 2017

View reviewed changes

neykov reviewed Feb 6, 2017

View reviewed changes

Explicitly set shutdown to false for external ExecutorService

2a3da72

grkvlt force-pushed the enhancement/threaded-repeater branch from 8f65875 to 2a3da72 Compare February 7, 2017 12:43

asfgit merged commit 2a3da72 into apache:master Feb 7, 2017

asfgit pushed a commit that referenced this pull request Feb 7, 2017

Closes #493

c62f84a

Make the Repeater class use a threads to execute the checks The Future returned by the Executor can be cancelled if it does not return a value after the required timeout.

grkvlt deleted the enhancement/threaded-repeater branch February 9, 2017 13:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make the Repeater class use a threads to execute the checks #493

Make the Repeater class use a threads to execute the checks #493

grkvlt commented Dec 15, 2016

geomacy commented Dec 16, 2016

neykov commented Dec 16, 2016

aledsage commented Jan 5, 2017

grkvlt commented Jan 11, 2017

grkvlt commented Jan 26, 2017

neykov left a comment

neykov Jan 26, 2017

grkvlt Jan 31, 2017

neykov Jan 26, 2017

grkvlt Jan 31, 2017

neykov Jan 26, 2017

neykov Feb 3, 2017

grkvlt commented Feb 6, 2017

neykov Feb 6, 2017

neykov commented Feb 7, 2017

		public ReferenceWithError<Boolean> runKeepingError() {
		Preconditions.checkState(body != null, "repeat() method has not been called to set the body");

Make the Repeater class use a threads to execute the checks #493

Make the Repeater class use a threads to execute the checks #493

Conversation

grkvlt commented Dec 15, 2016

geomacy commented Dec 16, 2016

neykov commented Dec 16, 2016

aledsage commented Jan 5, 2017

grkvlt commented Jan 11, 2017

grkvlt commented Jan 26, 2017

neykov left a comment

Choose a reason for hiding this comment

neykov Jan 26, 2017

Choose a reason for hiding this comment

grkvlt Jan 31, 2017

Choose a reason for hiding this comment

neykov Jan 26, 2017

Choose a reason for hiding this comment

grkvlt Jan 31, 2017

Choose a reason for hiding this comment

neykov Jan 26, 2017

Choose a reason for hiding this comment

neykov Feb 3, 2017

Choose a reason for hiding this comment

grkvlt commented Feb 6, 2017

neykov Feb 6, 2017

Choose a reason for hiding this comment

neykov commented Feb 7, 2017