Remove deprecated REST API endpoints #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, I also checked the JSGUI and it does not use any of the deprecated calls so you are good on this part |
|
👍 lgtm; have also tested a variety of |
asfgit
pushed a commit
that referenced
this pull request
Apr 18, 2017
Remove deprecated REST API endpoints This removes the deprecated REST API endpoints from Brooklyn 0.7.0. It also fixes the launcher configuration (as the `VersionApi` has been entirely removed) and unit tests. Please note that I didn't touch the `LocationApi` for a very specific reason: currently, this is the only of getting the locations defined within `brooklyn.properties`/`brooklyn.cfg` files. We need to figure out first how to handle those locations before removing the endpoints. As you can see, this is not in the scope of this PR.
|
Awesome, thanks @geomacy! Could you also take a look at apache/brooklyn-client#45 please? That will avoid the build to fail |
asfgit
pushed a commit
to apache/brooklyn-client
that referenced
this pull request
Apr 18, 2017
Remove deprecated REST API endpoints This requires apache/brooklyn-server#637
|
@tbouron that's done thanks |
asfgit
pushed a commit
to apache/brooklyn-client
that referenced
this pull request
Apr 19, 2017
Removed unused class Fixes broken jenkins builds, introduced by #45 and apache/brooklyn-server#637
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the deprecated REST API endpoints from Brooklyn 0.7.0. It also fixes the launcher configuration (as the
VersionApihas been entirely removed) and unit tests.Please note that I didn't touch the
LocationApifor a very specific reason: currently, this is the only way of getting the locations defined withinbrooklyn.properties/brooklyn.cfgfiles. We need to figure out first how to handle those locations before removing the endpoint. As you can see, this is not in the scope of this PR.