Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSGi] Generate random password if no security provider configured #69

Merged
merged 1 commit into from
Mar 30, 2016

Conversation

neykov
Copy link
Member

@neykov neykov commented Mar 17, 2016

Replicate classical launcher behaviour. Note that when accessing from localhost username will still be requested, but will accept any provider.

Replicate classical launcher behaviour. Note that when accessing from localhost username will still be requested, but will accept any provider.
@neykov neykov changed the title Generate random password if no security provider configured [OSGi] Generate random password if no security provider configured Mar 17, 2016
@neykov
Copy link
Member Author

neykov commented Mar 17, 2016

With this and #41 merged should change BrooklynUserWithRandomPasswordSecurityProvider to always ask for a password. Otherwise the browser will ask for password while the provider will authenticate any user when coming from localhost.

@ahgittin
Copy link
Contributor

@neykov should you / will you do the change you mention here or in a new PR ?

ahgittin added a commit to ahgittin/brooklyn-server that referenced this pull request Mar 28, 2016
@neykov
Copy link
Member Author

neykov commented Mar 28, 2016

Better do it in another PR, after sending an email to dev@a.o for the change. It will affect most users.
Also needs updating how BrooklynNode connects to self.
Or should we change behaviour just for Karaf?

@asfgit asfgit merged commit b7813d9 into apache:master Mar 30, 2016
@neykov neykov deleted the osgi/random-security-provider branch March 30, 2016 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants