Fix generics usage (for compilation in Eclipse) #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geomacy
reviewed
May 22, 2017
| @@ -372,7 +371,7 @@ public void testIgnoresWithNoPort() throws Exception { | |||
|
|
|||
| // Ugly casting in java, but easy to get passed this when constructed from YAML | |||
There was a problem hiding this comment.
don't need this comment any more?
geomacy
approved these changes
May 22, 2017
asfgit
pushed a commit
to apache/brooklyn-library
that referenced
this pull request
May 22, 2017
Fix generics usage (for compilation in Eclipse) Similar to apache/brooklyn-server#691
aledsage
force-pushed
the
generics-usage-for-eclipse-compiler
branch
from
1eb1a0b
to
15a203c
Compare
|
Thanks @geomacy - I've deleted that comment. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes generics compilation errors that the Eclipse compiler reports, with Java 8 (in Eclipse 4.6.3).