Winrm4j upgrade #81
Merged
Winrm4j upgrade #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use com.google.common.collect instead of org.testng.collections
Previously if the restart failed in some way (e.g. an error in the launch script or a timeout waiting for serviceUp), we would leave the expectedState as “starting”. This meant that serviceUp=false was not rendered as an error. Always setting expected=running is better, but is not great. For example, if a script fails in restart then we won’t mark the entity as onFire if the basic service-up checks still pass. This is different from the start() behaviour. But then we are doing less than in start (e.g. in start a script failure could mean that a WAR was not installed so the simple serviceUp reachability check would not be sufficient if customize() had failed).
|
Nice changes and cleanups! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also see the commit "softwareProcess.restart: even on error, set expected=running", and the details in that commit description.