-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing REST endpoints for karaf distribution #895
Conversation
@@ -75,6 +75,7 @@ limitations under the License. | |||
<bean id="apidocResourceBean" class="org.apache.brooklyn.rest.resources.ApidocResource"/> | |||
<bean id="applicationResourceBean" class="org.apache.brooklyn.rest.resources.ApplicationResource"/> | |||
<bean id="catalogResourceBean" class="org.apache.brooklyn.rest.resources.CatalogResource"/> | |||
<bean id="bundlesResourceBean" class="org.apache.brooklyn.rest.resources.BundleResource"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also need typesResourceBean
for TypeResource
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Endpoint added @aledsage
@@ -74,18 +74,20 @@ limitations under the License. | |||
<bean id="adjunctResourceBean" class="org.apache.brooklyn.rest.resources.AdjunctResource"/> | |||
<bean id="apidocResourceBean" class="org.apache.brooklyn.rest.resources.ApidocResource"/> | |||
<bean id="applicationResourceBean" class="org.apache.brooklyn.rest.resources.ApplicationResource"/> | |||
<bean id="bundlesResourceBean" class="org.apache.brooklyn.rest.resources.BundleResource"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor: I'd go for bundleResourceBean
to be consistent with all the others. Then good to merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aledsage updated
This change add some missing endpoint for the karaf distribution:
/v1/catalog/bundles
/v1/catalog/types