Show config values when jumping from App Wizard to YAML Preview #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -303,6 +303,7 @@ define([ | |||
| }, | |||
| previewStep:function () { | |||
| // no need for validation if going to composer | |||
| this.currentView.validate(); | |||
There was a problem hiding this comment.
The comment right above is valid. At that point, we shouldn't validate the model but send exactly what the user specified. So rather than calling validate here, I would add this above line 317:
this.model.spec.set("config", this.currentStep.getConfigMap());
|
Indeed, the config is skipped when we send the blueprint to the YAML editor, I commented on that part. Regarding the way the steps are connected, you can look at the global view definition and the |
bostko
force-pushed
the
fix-preview-composed-yaml
branch
from
b6acf26
to
561b08f
Compare
| @@ -303,6 +303,7 @@ define([ | |||
| }, | |||
| previewStep:function () { | |||
| // no need for validation if going to composer | |||
| this.currentView.model.spec.set("config", this.currentView.getConfigMap()); | |||
There was a problem hiding this comment.
Could you just add a comment stating what this does please? Will be useful for the future
bostko
force-pushed
the
fix-preview-composed-yaml
branch
from
561b08f
to
14ae022
Compare
|
Tested, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope the title explains what it is fixing
I see that the
StepDeploy.validatedoes more than validating the model.Any suggestions for separating this logic or renaming the validate method to
fillConfigAndValidate?I do not understand how
ModalWizard,ModalWizard.StepCreateandModalWizard.StepDeployare connected to each other.@tbouron any comments?