Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve bazel build. #1146

Closed
wants to merge 3 commits into from
Closed

Improve bazel build. #1146

wants to merge 3 commits into from

Conversation

hcoona
Copy link
Contributor

@hcoona hcoona commented Jun 18, 2020 •
edited
Loading

  • Run buildifier to format WORKSPACE & BUILD.
    • No manual change, only formatting it.
  • Reshape the bazel build dependencies.
    • Upgrade bazel external dependency version to help migrate to higher version of bazel.
    • Order external dependency by their inter-dependency relationship.
    • Move bazel external build file into third_party folder.
    • Rename BUILD -> BUILD.bazel to fit the rule in .gitignore & bazel community suggests.
    • Add sha256 for all external dependencies.

@hcoona hcoona changed the title Run buildifier to format WORKSPACE & BUILD. Improve bazel build. Jun 18, 2020
@hcoona
Copy link
Contributor Author

hcoona commented Jun 20, 2020

The failed checks is not related to this change.

@hcoona
Copy link
Contributor Author

hcoona commented Jun 22, 2020

@jamesge would you like to take a look at this MR? The failed CI check is not related to this change.

@hcoona
Copy link
Contributor Author

hcoona commented Aug 29, 2022

Superceded by #1657

@hcoona hcoona closed this Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@hcoona