Support parse proto-text format http request body #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwbmmm
reviewed
Feb 7, 2022
|
@hiberabyss Thanks for your contribution! Can you add some unit test for this feature? |
It's a little complicated to run test on M1 macOS, could this MR be merged first? Have tested this with my own service. |
brpc has not support M1 macOS yet, you can test it on a linux device. You can follow the compiling and testing guide here: https://github.com/apache/incubator-brpc/blob/master/docs/cn/getting_started.md |
FYI, add some ut for proto-text. |
wwbmmm
reviewed
Feb 15, 2022
|
@wwbmmm Could you have a look of this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.