fix hostname2ip fails when aux_buf is not long enough #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwbmmm
reviewed
Jun 23, 2022
|
LGTM |
wasphin
reviewed
Jun 23, 2022
serverglen
reviewed
Jun 24, 2022
|
@serverglen 修改了头文件顺序就coredump了？这个要怎么debug呢？ |
gdb看下堆栈呢？ |
那个core是因为test_butil里面有的case是预期要出core的，是正常的。 |
|
@wwbmmm 好了 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
使用Channel::Init("http://hostname", options)时，会在hostname2ip中通过gethostbyname_r获取dns的节点信息。如果hostname在dns中配置了很多节点，hostname2ip会因为aux_buf长度不够导致调用失败，从而导致Channel::Init失败。
解决方法：参考DomainNamingService获取节点信息的方法，当gethostbyname_r返回ERANGE，表示aux_buf长度不足时，将aux_buf长度增大一倍，重新调用gethostbyname_r获取节点信息，直到获取成功为止。