bvar_dump_tabs默认值的问题 #1920
Merged
bvar_dump_tabs默认值的问题 #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
看起来是 https://github.com/apache/incubator-brpc/pull/736/files#diff-c0b6d01ee136503e4e5072ef2fbeaf851a31a2a17419ea51aa5385e440371ee5 这个PR引入的问题，原来的SplitStringIntoKeyValuePairs有trim的逻辑，而新的KeyValuePairsSplitter没有trim的逻辑 @zyearn 看看怎么处理合适 |
Huixxi
added
discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bvar_dump_tabs默认值包含空格，导致创建的文件名字里有空格。
个人感觉也没有必要trim一下，严格要求不包含空格就行。