Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows to skip builds for markdown-file-only changes #2175

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

kiminno
Copy link
Contributor

@kiminno kiminno commented Mar 22, 2023

What problem does this PR solve?

Issue Number: N/A

Problem Summary:

  • The entire GitHub workflow is run, even for changes that do not require a build, such as for markdown file changes. This PR is an example of the entire workflow being run for an update to the oncall.md file. It takes approximately 30 minutes for the entire Github CI workflow to run and developers commit a standalone markdown file change at least 2 times per month.

What is changed and the side effects?

Changed:

  • Update GitHub workflow files to skip the ci-linux and ci-macos workflows for pushes and pull requests when the only changes are to markdown files. The result is less time spent waiting for builds to pass on both pushes and pull requests for Markdown file changes, which currently takes 30 minutes. Now, only the license check should run, which takes under 2 minutes.

Side effects:

  • Performance effects(性能影响): N/A

  • Breaking backward compatibility(向后兼容性): No


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wasphin
Copy link
Member

wasphin commented Mar 23, 2023

LGTM

@wasphin wasphin merged commit 1bd072e into apache:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants