Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS bazel build #2341

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Fix macOS bazel build #2341

merged 1 commit into from
Aug 3, 2023

Conversation

anakinxc
Copy link
Contributor

@anakinxc anakinxc commented Aug 2, 2023

What problem does this PR solve?

Issue Number:

Problem Summary:

#2306 introduced a new include in butil/macros.h, this dependency is missing in bazel macos_lib rule.

What is changed and the side effects?

Changed:

  • Added butil/string_printf.h to macos_lib header list.

Side effects:

  • Performance effects(性能影响):
    n/a
  • Breaking backward compatibility(向后兼容性):
    n/a

Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@serverglen
Copy link
Contributor

LGTM

1 similar comment
@chenBright
Copy link
Contributor

LGTM

@chenBright chenBright merged commit 0924f7f into apache:master Aug 3, 2023
16 checks passed
yanglimingcn pushed a commit to yanglimingcn/brpc that referenced this pull request Oct 31, 2023
yanglimingcn pushed a commit to yanglimingcn/brpc that referenced this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants