Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't delete when the file is /dev/null #2346

Merged
merged 1 commit into from
Aug 6, 2023
Merged

Conversation

zhaixiaojuan
Copy link
Contributor

What problem does this PR solve?

Issue Number: #2345

Problem Summary:
由于iobuf_unittest.cpp文件中append_store_append_cut测试用例删除/dev/null,导致在for循环中在执行open时重新创建了一个文件类型的/dev/null,从而引发系统问题

What is changed and the side effects?

Changed: 当检测到是/dev/null, 不对其进行删除

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@zyearn zyearn merged commit 0c7f178 into apache:master Aug 6, 2023
16 checks passed
yanglimingcn pushed a commit to yanglimingcn/brpc that referenced this pull request Oct 31, 2023
yanglimingcn pushed a commit to yanglimingcn/brpc that referenced this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants