Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed long to size_t in AnnotateBenignRaceSized function #2403

Merged
merged 1 commit into from
Oct 13, 2023
Merged

changed long to size_t in AnnotateBenignRaceSized function #2403

merged 1 commit into from
Oct 13, 2023

Conversation

Divyansh200102
Copy link
Contributor

@Divyansh200102 Divyansh200102 commented Oct 8, 2023 •
edited
Loading

fixes #1931

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):

Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@Divyansh200102 Divyansh200102 changed the title changed long to size_t in AnnotateBenignRaceSized function changed long to size_t in AnnotateBenignRaceSized function #1931 Oct 8, 2023
@Divyansh200102 Divyansh200102 changed the title changed long to size_t in AnnotateBenignRaceSized function #1931 changed long to size_t in AnnotateBenignRaceSized function Oct 8, 2023
@Divyansh200102 Divyansh200102 reopened this Oct 8, 2023
@chenBright
Copy link
Contributor

LGTM

@Divyansh200102
Copy link
Contributor Author

LGTM

please try to merge it as soon as you get time @chenBright

@chenBright
Copy link
Contributor

@wwbmmm Please review this PR when you have time.

@chenBright chenBright requested a review from wwbmmm October 9, 2023 07:00
@wwbmmm wwbmmm merged commit e8b3493 into apache:master Oct 13, 2023
32 checks passed
@Divyansh200102 Divyansh200102 deleted the parameter-long-size_t branch October 18, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwbmmm wwbmmm Awaiting requested review from wwbmmm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

size parameter of AnnotateBenignRaceSized should be typed size_t instead of long
3 participants
@Divyansh200102 @chenBright @wwbmmm