This repository has been archived by the owner on Aug 4, 2022. It is now read-only.
java command: escape classpath entries in the pathing jar manifest #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks - fix merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed that the java command fails when using long classpaths on windows, while the classpath also has entries that contain spaces.
The issue is that the manifest in the pathing jar uses space as a separator between classpath entries, and entries aren't URI-encoded. A classpath entry with a space in it is incorrectly treated as 2 entries.
PR is for an older revision, as we use buildr 1.4 internally. It should be easy enough to merge though, as it's a one-liner fix.