-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have absolute path for conf-root #27
Conversation
6b54935
to
4824e8a
Compare
4824e8a
to
33d4b62
Compare
33d4b62
to
1111073
Compare
I am concerned whether this may leak element name (which is part of build-root) into binaries. I will iterate more on whether we can have correct reldir in this case. |
45c85ee
to
11cff5b
Compare
@gtristan does the test image not have realpath? |
I don’t know, but I’m doubtful of relying on expansion of |
Also given we use |
I am having some trouble figuring out how to handle the relative path generation with all these interdependent variables. freedesktop-sdk mostly had generation as a single flat sh script, hence why it was easy. |
Especially existence of conf-root and conf-cmd seem to make configuring autotools harder, not easier. (I'm not sure if they are justified from API point of view: at the point where you might want to set conf-root to anything else than ".", you would instead typically set command-subdir; conf-cmd is just a thin wrapper on top of conf-root) |
Also conf-root as a concept is just wrong. You run configure and autoreconf from different directory. build-dir is a commonly required concept (eg glibc cannot be built without it). And autogen typically cannot be run from another directory. Many autogen scripts also forbid running them from any other directory than the directory where autogen is in. So conf-root cannot ever be changed from |
This enables calling configure from build-root to work
11cff5b
to
4719639
Compare
Okay. I think this is a lost cause. I will revert the previous MR. I think the autotools.yml in this repo is broken by design and cannot be fixed without breaking API. |
This enables calling configure from build-root to work #28