Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have absolute path for conf-root #27

Closed
wants to merge 1 commit into from

Conversation

nanonyme
Copy link
Contributor

@nanonyme nanonyme commented Aug 17, 2022

This enables calling configure from build-root to work #28

@nanonyme nanonyme force-pushed the build-dir-take-two branch 2 times, most recently from 6b54935 to 4824e8a Compare August 17, 2022 20:38
@nanonyme nanonyme marked this pull request as ready for review August 17, 2022 20:43
@nanonyme nanonyme closed this Aug 17, 2022
@nanonyme nanonyme reopened this Aug 17, 2022
@nanonyme
Copy link
Contributor Author

I am concerned whether this may leak element name (which is part of build-root) into binaries. I will iterate more on whether we can have correct reldir in this case.

@nanonyme nanonyme force-pushed the build-dir-take-two branch 2 times, most recently from 45c85ee to 11cff5b Compare August 21, 2022 09:16
@nanonyme
Copy link
Contributor Author

@gtristan does the test image not have realpath?

@gtristan
Copy link
Contributor

@gtristan does the test image not have realpath?

I don’t know, but I’m doubtful of relying on expansion of realpath in default upstream autotools build instructions

@gtristan
Copy link
Contributor

@gtristan does the test image not have realpath?

I don’t know, but I’m doubtful of relying on expansion of realpath in default upstream autotools build instructions

Also given we use /bin/sh by default I wouldn’t want to introduce bash specific $(command …) expansion

@nanonyme
Copy link
Contributor Author

nanonyme commented Aug 21, 2022

I am having some trouble figuring out how to handle the relative path generation with all these interdependent variables. freedesktop-sdk mostly had generation as a single flat sh script, hence why it was easy.

@nanonyme
Copy link
Contributor Author

nanonyme commented Aug 21, 2022

Especially existence of conf-root and conf-cmd seem to make configuring autotools harder, not easier. (I'm not sure if they are justified from API point of view: at the point where you might want to set conf-root to anything else than ".", you would instead typically set command-subdir; conf-cmd is just a thin wrapper on top of conf-root)

@nanonyme
Copy link
Contributor Author

Also conf-root as a concept is just wrong. You run configure and autoreconf from different directory. build-dir is a commonly required concept (eg glibc cannot be built without it). And autogen typically cannot be run from another directory. Many autogen scripts also forbid running them from any other directory than the directory where autogen is in. So conf-root cannot ever be changed from . without breaking said projects....

This enables calling configure from build-root to work
@nanonyme
Copy link
Contributor Author

Okay. I think this is a lost cause. I will revert the previous MR. I think the autotools.yml in this repo is broken by design and cannot be fixed without breaking API.

@nanonyme nanonyme closed this Aug 21, 2022
@nanonyme nanonyme deleted the build-dir-take-two branch August 21, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants