-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecation warning for Meson #38
Conversation
Turns out we're been doing it wrong since Meson 0.42. |
"Doing it wrong since Meson 0.42" would imply that we actually informed users of that for the last 5 years. 🤣 As a matter of compatibility, it is however true that making this change works since relatively forever. |
Yeah, that's kind of what I was going for. This is unlikely to break anything (except cache keys) and the deprecated way will eventually go away so it's better to do it now when majority of users still use BuildStream 1 and not BuildStream 2. |
@eli-schwartz your point is valid though. I probably would not have noticed this being deprecated now either if gstreamer doc created hadn't broken with update to Meson 0.64.1. |
I'm tempted to change ninja too (and use Not sure what @gtristan would think of this, but it at least implies we need to block the buildstream-plugins 2.0 release. |
I agree but if we do that, we should also change API which is forbidden kind of |
It's not great going towards something that should last next decade with legacy ways of doing things. |
|
It would probably be most reasonable if the variables (API) were meson-build and meson-install and former would directly invoke ninja whereas latter would invoke meson install. The fact meson-build directly invokes ninja is an implementation detail and you could override it to something completely different. |
@abderrahim can we merge this though? I can make new PR that is explicitly about changing API. |
See mesonbuild/meson@3c7ab54