CALCITE-5009 Transparent JDBC connection re-creation may lead to data… #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think that the checkstyle/rat errors are related to this patch. |
|
I've fixed the build, you should be able to rebase on top of master to get the tests passing. |
… loss CALCITE-903 has introduced a transaprent reconnection feature, which will open a new server-side connection in case it is expired from the server side connection cache. While this is convinient for most read-only analytical workload, this can cause a number a problems, including data loss for transactional connections. This patch disables the transparent reconnect feature by default, and adds the transparent_reconnection property, which re-enables it when set to true.
|
thank you @F21. |
joshelser
approved these changes
Apr 1, 2022
There was a problem hiding this comment.
I was going to suggest that we also update https://github.com/apache/calcite-avatica/blob/master/site/_docs/client_reference.md but I see that it's already out of date. We can merge this change and then go back and make sure the client_reference.md page is updated for all of the user-facing configuration properties (maybe adding the client retries property there, too).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… loss
Change-Id: Iaf10b6e4d4760cce9a7fabf1762a94501684f23d