[CALCITE-5494] Time zone tests in DateTimeUtilsTest should pass in Europe/London #206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DateTimeUtilsTest.testSqlDateToUnixDateWithCustomCalendar
test fails in the Europe/London time zone. The issue is due to the use ofTimeZone.setRawOffset(int)
which expects the provided value to be the offset from GMT, but the test provides the offset from UTC.I tested the fix in several time zones and they all passed.