[CALCITE-5536] Clean up some of the magic numbers in AvaticaResultSetConversionsTest and AbstractCursor #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wnob Can you open a jira issue for this? |
wnob
changed the title
stoty
reviewed
Feb 17, 2023
| @@ -173,14 +173,14 @@ protected Accessor createAccessor(ColumnMetaData columnMetaData, | |||
| default: | |||
| throw new AssertionError("bad " + columnMetaData.type.rep); | |||
| } | |||
| case 2013: // TIME_WITH_TIMEZONE | |||
There was a problem hiding this comment.
Nit:
While these changes are fine, they do not agree with the commit message. (i.e this is not a test refactor)
There was a problem hiding this comment.
Change the commit message to [CALCITE-5536] Clean up some of the magic numbers in AvaticaResultSetConversionsTest and AbstractCursor and I think we're good.
wnob
changed the title
wnob
changed the title
|
You have only changed the PR name, and not the commit message, @wnob. |
|
Committed with fixed commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn a bunch of magic numbers into named constants without changing any values, and add extra comments where appropriate.
In
AvaticaResultSetConversionsTest, I renamedDEFAULT_CALENDARtoUTC_CALENDARbecause that's a more accurate name. The definition ofDateTimeUtils.calendar()isCalendar.getInstance(UTC_ZONE, Locale.ROOT).