[CALCITE-1353] Convert first_frame_max_size to an int32 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A uint64 is wrong because -1 is a valid value and Java can only handle a max of 2**32, not 2**64, elements.
wnob
pushed a commit
to wnob/calcite-avatica
that referenced
this pull request
Feb 14, 2024
…pache#5) Co-authored-by: Justin Swett <jswett@google.com>
wnob
pushed a commit
to wnob/calcite-avatica
that referenced
this pull request
Feb 15, 2024
…pache#5) Co-authored-by: Justin Swett <jswett@google.com>
Anthrino
pushed a commit
to Anthrino/calcite-avatica
that referenced
this pull request
Jun 3, 2024
…pache#5) Co-authored-by: Justin Swett <jswett@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A uint64 is wrong because -1 is a valid value and Java can only
handle a max of 2^32, not 2^64, elements.