[CALCITE-2776] Wrong value when accessing struct types with one attribute (Stamatis Zampetakis) #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zabetak Can this be merged? I'd like to get this into the next avatica release if possible. |
|
I just waited somebody to have a second look! I am confident for the change and since @hsyuan had a look it should be ready to go ;) |
…bute 1. Remove special treatment for struct types with one attribute in AbstractCursor#createAccessor. 2. Add parameterized unit test for testing struct accessors using multiple internal representations for struct types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove special treatment for struct types with one attribute in AbstractCursor#createAccessor.
Add parameterized unit test for testing struct accessors using multiple internal representations for struct types.