Skip to content

Commit

Permalink
Clarify why squash commits option in GitHub PR merge is disabled
Browse files Browse the repository at this point in the history
Unfortunately, the button loses committer info as follows (it uses GitHub noreply for committer):

commit a8e50734e0460e506f1762fbe0f628bcb444b8f5
Author: Denys Kuzmenko <dk...@cloudera.com>
AuthorDate: Tue Nov 30 10:09:06 2021 +0200
Commit: GitHub <no...@github.com>
CommitDate: Tue Nov 30 09:09:06 2021 +0100
  • Loading branch information
vlsi committed Dec 2, 2021
1 parent f3e2f04 commit 8a266e6
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .asf.yaml
Expand Up @@ -22,7 +22,10 @@ github:
issues: false
projects: false
enabled_merge_buttons:
# "squash and merge" replaces committer with noreply@github, and we don't want that
# See https://lists.apache.org/thread/vxxpt1x316kjryb4dptsbs95p66d9xrv
squash: false
# We prefer linear history, so creating merge commits is disabled in UI
merge: false
rebase: true
notifications:
Expand Down

0 comments on commit 8a266e6

Please sign in to comment.