Fixed up nullable declarations

apache · May 13, 2024 · a549b02 · a549b02
1 parent a960fc5
commit a549b02
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/core/src/main/java/org/apache/calcite/util/format/postgresql/NumberFormatPattern.java b/core/src/main/java/org/apache/calcite/util/format/postgresql/NumberFormatPattern.java
@@ -16,6 +16,8 @@
  */
 package org.apache.calcite.util.format.postgresql;
 
+import org.checkerframework.checker.nullness.qual.Nullable;
+
 import java.text.ParsePosition;
 import java.time.ZonedDateTime;
 import java.util.Locale;
@@ -34,7 +36,7 @@ protected NumberFormatPattern(Function<ZonedDateTime, String> converter, String.
     this.patterns = patterns;
   }
 
-  @Override public String convert(ParsePosition parsePosition, String formatString,
+  @Nullable @Override public String convert(ParsePosition parsePosition, String formatString,
       ZonedDateTime dateTime) {
     String formatStringTrimmed = formatString.substring(parsePosition.getIndex());
 

diff --git a/core/src/main/java/org/apache/calcite/util/format/postgresql/StringFormatPattern.java b/core/src/main/java/org/apache/calcite/util/format/postgresql/StringFormatPattern.java
@@ -33,7 +33,7 @@ protected StringFormatPattern(String... patterns) {
     this.patterns = patterns;
   }
 
-  @Override public String convert(ParsePosition parsePosition, String formatString,
+  @Nullable @Override public String convert(ParsePosition parsePosition, String formatString,
       ZonedDateTime dateTime) {
     String formatStringTrimmed = formatString.substring(parsePosition.getIndex());
 

diff --git a/core/src/main/java/org/apache/calcite/util/format/postgresql/TimeZoneHoursFormatPattern.java b/core/src/main/java/org/apache/calcite/util/format/postgresql/TimeZoneHoursFormatPattern.java
@@ -32,8 +32,8 @@ public TimeZoneHoursFormatPattern() {
     super("TZH");
   }
 
-  @Override String dateTimeToString(final ZonedDateTime dateTime, boolean haveFillMode,
-      @Nullable final String suffix, final Locale locale) {
+  @Override String dateTimeToString(ZonedDateTime dateTime, boolean haveFillMode,
+      @Nullable String suffix, Locale locale) {
     return String.format(
         Locale.ROOT,
         "%+02d",

diff --git a/...src/main/java/org/apache/calcite/util/format/postgresql/TimeZoneMinutesFormatPattern.java b/...src/main/java/org/apache/calcite/util/format/postgresql/TimeZoneMinutesFormatPattern.java
@@ -32,8 +32,8 @@ public TimeZoneMinutesFormatPattern() {
     super("TZM");
   }
 
-  @Override String dateTimeToString(final ZonedDateTime dateTime, boolean haveFillMode,
-      @Nullable final String suffix, final Locale locale) {
+  @Override String dateTimeToString(ZonedDateTime dateTime, boolean haveFillMode,
+      @Nullable String suffix, Locale locale) {
     return String.format(
         Locale.ROOT,
         "%02d",