[CALCITE-2960] CalciteCatalogReader now uses config.caseSensitive() to get functions… #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @LaiZhou, Any JIRA opened for this? |
|
@hsyuan No JIRA issue yet. Is it required to track this PR ? I think this case may be simple enough. |
|
Yes, no matter how simple the code change is, we need a JIRA logged for it. |
LaiZhou
changed the title
LaiZhou
changed the title
|
@hsyuan done . CALCITE-2960 |
|
@LaiZhou This problem is fixed in CALCITE-2928 |
|
Closing this PR, since it has been resolved in commit: 136c9c5, feel free to reopen it if you don't think so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CalciteCatalogReader now uses config.caseSensitive() to get functions, not a hard-coding
true.