[CALCITE-3281] Support mixed Primitive types for BinaryExpression evaluate method. #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanlin-Lynn
force-pushed
the
yanlin-binaryExpr
branch
3 times, most recently
from
54ea921
to
d84d417
Compare
yanlin-Lynn
force-pushed
the
yanlin-binaryExpr
branch
from
d84d417
to
b3ec23e
Compare
…aluate method (Wang Yanlin)
yanlin-Lynn
force-pushed
the
yanlin-binaryExpr
branch
from
b3ec23e
to
8bf0635
Compare
zinking
reviewed
Oct 25, 2019
No, it will not. |
danny0405
force-pushed
the
master
branch
2 times, most recently
from
80f411d
to
ca27fe9
Compare
|
Thanks for PR, @yanlin-Lynn ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the value of expression0 and expression1 must be the same type. Otherwise we might a ClassCastException, as shown in JIRA CALCITE-3281.
This PR is an improvement to support using different primitive types for expression0 and expression1 of BinaryExpression, so that, make it suite for evaluate in more cases.