[CALCITE-1178] Allow SqlBetweenOperator to compare DATE and TIMESTAMP #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add implicit type coercion rules for BETWEEN operator and add test cases * For comparison of NUMERIC and CHARACTER, we coerce the CHARACTER to NUMERIC type which is breaking change.(Before this patch, CHARACTER would be coerced to INT during sql-to-rel conversion) * For "DATETIME and CHARACTER" comparison and equality, add coercion rules during sql node validation, before this patch, the coercion happens during sql-to-rel conversion * Some code refactoring for TypeCoercionConverterTest
danny0405
force-pushed
the
CALCITE-1178
branch
from
84fea7b
to
9ca0bda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cases
NUMERIC type which is breaking change.(Before this patch, CHARACTER would
be coerced to INT during sql-to-rel conversion)
node validation, before this patch, the coercion happens during sql-to-rel conversion