Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CALCITE-3410] Simplify RelOptRulesTest and HepPlannerTest by making … #1505

Merged
merged 1 commit into from Oct 15, 2019
Merged

[CALCITE-3410] Simplify RelOptRulesTest and HepPlannerTest by making … #1505

merged 1 commit into from Oct 15, 2019

Conversation

danny0405
Copy link
Contributor

…test methods fluent

  • Add method 'Sql.withTester'
  • In RelOptTestBase, deprecate checkPlanning method

@danny0405
[CALCITE-3410] Simplify RelOptRulesTest and HepPlannerTest by making …
d65aeac 
…test methods fluent

* Add method 'Sql.withTester'
* In RelOptTestBase, deprecate checkPlanning method
hsyuan
hsyuan approved these changes Oct 14, 2019
View reviewed changes
Copy link
Member

@hsyuan hsyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@danny0405 danny0405 merged commit 8da131c into apache:master Oct 15, 2019
@danny0405 danny0405 deleted the CALCITE-3410 branch October 15, 2019 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsyuan hsyuan hsyuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@danny0405 @hsyuan