Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CALCITE-3758] FilterTableScanRule generate wrong mapping for filter … #1775

Merged
merged 1 commit into from Apr 22, 2020
Merged

[CALCITE-3758] FilterTableScanRule generate wrong mapping for filter … #1775

merged 1 commit into from Apr 22, 2020

Conversation

jinxing64
Copy link
Contributor

…condition when underlying is BindableTableScan (Jin Xing)

@jinxing64 jinxing64 force-pushed the CALCITE-3758 branch 3 times, most recently from b379b69 to a6cfea0 Compare April 15, 2020 09:31
@jinxing64
Copy link
Contributor Author

hmm,, test failed, it seems to be flaky and working by #1916

@jinxing64
[CALCITE-3758] FilterTableScanRule generate wrong mapping for filter …
4f2abcd 
…condition when underlying is BindableTableScan (Jin Xing)
@jinxing64
Copy link
Contributor Author

@julianhyde @hsyuan
Could you please take a look at this ? :D

@hsyuan
Copy link
Member

hsyuan commented Apr 15, 2020

Will do.

@hsyuan hsyuan added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label Apr 22, 2020
@hsyuan hsyuan merged commit 55c5853 into apache:master Apr 22, 2020
@jinxing64 jinxing64 deleted the CALCITE-3758 branch April 23, 2020 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsyuan hsyuan hsyuan approved these changes

Assignees
No one assigned
Labels
LGTM-will-merge-soon Overall PR looks OK. Only minor things left.
Projects
None yet
Milestone
No milestone
2 participants
@jinxing64 @hsyuan