Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CALCITE-3783] PruneEmptyRules#JOIN_RIGHT_INSTANCE wrong behavior for JoinRelType.ANTI #1796

Merged
merged 1 commit into from Feb 12, 2020
Merged

[CALCITE-3783] PruneEmptyRules#JOIN_RIGHT_INSTANCE wrong behavior for JoinRelType.ANTI #1796

merged 1 commit into from Feb 12, 2020

Conversation

rubenada
Copy link
Contributor

Jira ticket: CALCITE-3783

chunweilei
chunweilei reviewed Feb 12, 2020
View reviewed changes
Copy link
Contributor

@chunweilei chunweilei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

danny0405
danny0405 approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@danny0405 danny0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests looks great !

@rubenada rubenada merged commit 10a5b8a into apache:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunweilei chunweilei chunweilei left review comments

@danny0405 danny0405 danny0405 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rubenada @danny0405 @chunweilei