[CALCITE-1080] Cassandra adapter #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelmior
force-pushed
the
cassandra
branch
2 times, most recently
from
85061dc
to
150dae1
Compare
michaelmior
force-pushed
the
cassandra
branch
from
150dae1
to
94025f6
Compare
| </execution> | ||
| </executions> | ||
| </plugin> | ||
| <plugin> |
There was a problem hiding this comment.
Seems unnecessary to have the maven-release-plugin here.
There was a problem hiding this comment.
I'm not really familiar with Maven. I just copied this from mongodb/pom.xml. Aren't individual projects released as separate artifacts? I assumed the release plugin was necessary to coordinate the release process. If not, I can remove.
There was a problem hiding this comment.
Ah, ok. No, it shouldn't be necessary to define any plugin unless you have some special configuration necessary for that plugin. If you copied from the mongodb module, that's fine. I can clean up every at once later :)
michaelmior
force-pushed
the
cassandra
branch
from
51de64e
to
a6c2682
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the basis for a working Cassandra adapter for Calcite. There's still a lot to be done, but the basics are working. Currently there are rules for filtering, sorting, and projections. There are some basic integration tests written which test each of these. The tests use a fork of calcite-test-dataset which would presumably be merged along with this work when the time comes. Tests can be run the same as with MongoDB.
I'd love to get some early feedback and see what it will take to get this merged so others can start playing with it.
https://issues.apache.org/jira/browse/CALCITE-1080