[CALCITE-3979] Simplification might have removed CAST expressi… #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncorrectly ReduceExpressionsRule might have removed cast expressions and inadvertly changed the type of some subexpressions. In case the rewriting have at some point arrived at: CAST(CAST(X,T),T) AND <(CAST(X,T),N)
|
@chunweilei , @julianhyde : any objections against removing this logic from ReduceExpressionsRule? |
kgyrtkirk
added
the
LGTM-will-merge-soon
kgyrtkirk
changed the title
|
@kgyrtkirk As I said in the JIRA case, I really don't know what's safe to remove. It seems that there is a bunch of code to remove casts and there may not be a sound basis for that code. |
|
I don't see any reason to keep this logic any longer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ncorrectly
ReduceExpressionsRule might have removed cast expressions and inadvertly changed the type of some subexpressions.
In case the rewriting have at some point arrived at: CAST(CAST(X,T),T) AND <(CAST(X,T),N)