[CALCITE-4156] ReflectiveRelMetadataProvider constructor should throw an exception (instead of assertion) when called with an empty map #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… an exception (instead of assertion) when called with an empty map
rubenada
added
the
LGTM-will-merge-soon
danny0405
reviewed
Aug 6, 2020
core/src/main/java/org/apache/calcite/rel/metadata/ReflectiveRelMetadataProvider.java
Show resolved
Hide resolved
amaliujia
reviewed
Aug 6, 2020
| @@ -78,7 +78,9 @@ protected ReflectiveRelMetadataProvider( | |||
| ConcurrentMap<Class<RelNode>, UnboundMetadata> map, | |||
| Class<? extends Metadata> metadataClass0, | |||
| Multimap<Method, MetadataHandler> handlerMap) { | |||
| assert !map.isEmpty() : "are your methods named wrong?"; | |||
| if (map.isEmpty()) { | |||
| throw new IllegalArgumentException("ReflectiveRelMetadataProvider methods map is empty"); | |||
There was a problem hiding this comment.
Sorry I missed your PR.
Why not use CheckArgument in Guava?
There was a problem hiding this comment.
Thanks for the feedback @amaliujia , you are right, I am considering open a follow-up PR to change it into Preconditions.checkArgument
There was a problem hiding this comment.
@amaliujia please check #2100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: CALCITE-4156
ReflectiveRelMetadataProvider's constructor verifies that it is not created with an empty map, using an assertion. However, this is not the most reliable way of verifying this situation, since assertions can be deactivated. In such scenario, we could silently end up having an invalid ReflectiveRelMetadataProvider, with no actual methods attached.
Also, since the map is private and has no getter, there is no way for a caller module to verify this situation on its side.
For this reason, it is proposed a minor change: replace the assertion with an IllegalArgumentException, which will work in 100% of the cases and will always prevent constructing an invalid ReflectiveRelMetadataProvider.