[CALCITE-4265] Improve error message when CAST to unknown type (Louis #2326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny0405
reviewed
Jan 26, 2021
| @@ -1759,6 +1759,9 @@ protected SqlSelect createSourceSelectForDelete(SqlDelete call) { | |||
| @Override public RelDataType getValidatedNodeType(SqlNode node) { | |||
| RelDataType type = getValidatedNodeTypeIfKnown(node); | |||
| if (type == null) { | |||
| if (node.isA(ImmutableSet.of(SqlKind.IDENTIFIER))) { | |||
| throw newValidationError(node, RESOURCE.unknownIdentifier(node.toString())); | |||
There was a problem hiding this comment.
How about using node.getKind() == SqlKind.IDENTIFIER ?
There was a problem hiding this comment.
Done.
I forced push the commit since this is a small change whose history probably should not be kept. Curious what the recommended approach is for ammending PRs in calcite.
xwkuang5
force-pushed
the
calcite-4265-second-attempt
branch
from
692f3a9
to
e3d0011
Compare
Kuang) If SqlNode is an Identifier node whose type can not be derived, throws a validation error instead of an UnsupportedOperationException to improve error message.
xwkuang5
force-pushed
the
calcite-4265-second-attempt
branch
from
e3d0011
to
68615e6
Compare
danny0405
approved these changes
Jan 27, 2021
Hi Danny, when can we merge this PR? |
XuQianJin-Stars
pushed a commit
to XuQianJin-Stars/calcite
that referenced
this pull request
Jul 14, 2021
Kuang) If SqlNode is an Identifier node whose type can not be derived, throws a validation error instead of an UnsupportedOperationException to improve error message. close apache#2326
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kuang)
If SqlNode is an Identifier node whose type can not be derived, throws
a validation error instead of an UnsupportedOperationException to improve
error message.