[CALCITE-4584] Using function in partition by list of over window cause converting exception #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanlin-Lynn
force-pushed
the
expr_in_over
branch
from
76f1321
to
6eee9fa
Compare
chunweilei
reviewed
Apr 28, 2021
core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml
Outdated
Show resolved
Hide resolved
yanlin-Lynn
force-pushed
the
expr_in_over
branch
3 times, most recently
from
8d10c20
to
11051ef
Compare
|
hi, @chunweilei , any more problem for this PR? |
…se converting exception (Wang Yanlin)
yanlin-Lynn
force-pushed
the
expr_in_over
branch
from
11051ef
to
b668f74
Compare
yanlin-Lynn
added
the
LGTM-will-merge-soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When disable the sql validator to expand identifier, using function expr in the partition by list of over window will cause exception. See jira:CALCITE-4584 for mode details.