[CALCITE-4899] Support hint for lateral table syntax #2696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danny0405 please take a look, if you have time, thanks |
danny0405
reviewed
Jan 23, 2022
core/src/main/java/org/apache/calcite/sql/SqlCorrelateTableRef.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java
Outdated
Show resolved
Hide resolved
|
@danny0405 I have updated the commit, please take a look |
|
@danny0405 I have updated the commit, please take a look, thanks |
Tartarus0zm
force-pushed
the
CALCITE-4899
branch
from
a0171cd
to
6bf2b30
Compare
Tartarus0zm
force-pushed
the
CALCITE-4899
branch
from
978ddff
to
fdf13ed
Compare
|
I can not find any vendor that supports hints for functions, let's be conservative here, does the query hints like /*+ tvf_join('hash', 'table name') */works here ? You can add custom validations for the hint anyway. |
julianhyde
force-pushed
the
main
branch
2 times, most recently
from
8a5cf83
to
cf7f71b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Support hint for lateral table syntax
Verifying this change
SqlHintsConverterTestto validate the hint could be propagated to CorrelateRelToSqlConverterTest