[CALCITE-5040] SqlTypeFactoryTest.testUnknownCreateWithNullabilityTypeConsistency fails #2744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eConsistency fails [CALCITE-4872] added an UNKNOWN type that was implemented in some places by class SqlTypeFactoryImpl.UnknownSqlType, but in others by BasicSqlType. This would cause SqlTypeFactoryTest.testUnknownCreateWithNullabilityTypeConsistency to succeed or fail non-deterministically, depending on which of the above had made it into the map of canonical type instances. This commit solves the problem by removing class SqlTypeFactoryImpl.UnknownSqlType and always using BasicSqlType.
liyafan82
approved these changes
Mar 15, 2022
|
LGTM |
zabetak
approved these changes
Mar 15, 2022
| @@ -93,7 +93,7 @@ public SqlTypeFactoryImpl(RelDataTypeSystem typeSystem) { | |||
| } | |||
|
|
|||
| @Override public RelDataType createUnknownType() { | |||
There was a problem hiding this comment.
By adding UNKNOWN under SqlTypeName enum we are essentially making it a basic SQL type so we could consider deprecating and eventually removing the createUnknownType API. It's probably out of the scope of this PR but if it makes sense we could log a followup JIRA to tackle it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CALCITE-4872] added an UNKNOWN type that was implemented in some
places by class SqlTypeFactoryImpl.UnknownSqlType, but in others
by BasicSqlType. This would cause
SqlTypeFactoryTest.testUnknownCreateWithNullabilityTypeConsistency
to succeed or fail non-deterministically, depending on which of the
above had made it into the map of canonical type instances.
This commit solves the problem by removing class
SqlTypeFactoryImpl.UnknownSqlType and always using BasicSqlType.